Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify require-return-type about annotateUndefined #355

Merged
merged 4 commits into from Jan 8, 2019

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Sep 21, 2018

With the following:

async () => {};

This code will throw error when the setting is ['always', { 'annotateUndefined': false }]. The async function is return Promise<void>, but I think this is the same as void for async function. So, this PR is used to make Promise<void> like void when using async function.

@gajus gajus self-requested a review October 1, 2018 10:32
@HsuTing
Copy link
Contributor Author

HsuTing commented Jan 8, 2019

Hello, will this problem be solved?

@gajus gajus merged commit a405931 into gajus:master Jan 8, 2019
@gajus
Copy link
Owner

gajus commented Jan 8, 2019

Thank you

@HsuTing HsuTing deleted the modify-require-return-type branch January 8, 2019 08:20
@gajus
Copy link
Owner

gajus commented Jan 8, 2019

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants