Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of zertosh/eslint-plugin-flow-vars #36

Merged
merged 17 commits into from
Jul 27, 2016
Merged

Port of zertosh/eslint-plugin-flow-vars #36

merged 17 commits into from
Jul 27, 2016

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Jul 25, 2016

This is a port of zertosh/eslint-plugin-flow-vars adapted to eslint-plugin-flowtype's coding style.

Fixes #35

@@ -515,4 +520,61 @@ type FooType = {};
type foo = {};
```

## Rules (suppressing)
Copy link
Owner

@gajus gajus Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from the files in .README. You need to create a file for the rule here .README/rules and then include the file into the main template here .README/README.md. Then you need to run npm run readme to generate the README.md document.

@gajus
Copy link
Owner

gajus commented Jul 25, 2016

I have added https://github.com/gajus/eslint-plugin-flowtype/blob/master/CONTRIBUTING to avoid confusion in the future.

This is a port of [zertosh/eslint-plugin-flow-vars](https://github.com/zertosh/eslint-plugin-flow-vars) adapted to eslint-plugin-flowtype's coding style.

Fixes #35
@zertosh
Copy link
Contributor Author

zertosh commented Jul 25, 2016

Done, but the doc generation tool (like the test script) assume a very rigid structure for tests – this works fine for rules that report errors, but not for these rules that suppress them. What do you suggest I do?

@zertosh
Copy link
Contributor Author

zertosh commented Jul 25, 2016

Also, let me know if you want me to squash the commits.

@gajus
Copy link
Owner

gajus commented Jul 26, 2016

Also, let me know if you want me to squash the commits.

No need.

@gajus
Copy link
Owner

gajus commented Jul 26, 2016

@zertosh I have made couple of changes to your PR (https://github.com/zertosh/eslint-plugin-flowtype/pull/1). Please review them. If you are happy with these changes, please merge them into the PR branch and I will merge this PR.

If not, raise your suggestions.

@gajus gajus merged commit 646440e into gajus:master Jul 27, 2016
@gajus
Copy link
Owner

gajus commented Jul 27, 2016

Thank you!

@zertosh
Copy link
Contributor Author

zertosh commented Aug 4, 2016

I added a deprecation notice to eslint-plugin-flow-vars's README and on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants