Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixed to no-weak-types #362

Merged
merged 1 commit into from Oct 13, 2018
Merged

Conversation

kangax
Copy link
Contributor

@kangax kangax commented Oct 12, 2018

Fixes #361

@kangax
Copy link
Contributor Author

kangax commented Oct 12, 2018

@gajus my concern is that this is not backward-compatible (from what I can tell) since mixed will now be reported unless disabled explicitly.

@gajus
Copy link
Owner

gajus commented Oct 13, 2018

Sorry, I meant as a configuration.

@kangax
Copy link
Contributor Author

kangax commented Oct 13, 2018

@gajus you mean as a separate rule?

@gajus
Copy link
Owner

gajus commented Oct 13, 2018

@gajus you mean as a separate rule?

I think it doesn't necessitate a separate rule.

However, flowtype/no-weak-types could accept a configuration that lists what a weak type is, overriding the default list.

Alternatively, a new rule, no-restricted-types could be added that allows to list restricted types, such as mixed.

@kangax
Copy link
Contributor Author

kangax commented Oct 13, 2018

Hm, not sure I understand. Isn't the rule already accepting a configuration? I just added another option for mixed there.

@gajus
Copy link
Owner

gajus commented Oct 13, 2018

Hm, not sure I understand. Isn't the rule already accepting a configuration? I just added another option for mixed there.

Sorry. Ignore my comments. :-)

@gajus gajus merged commit 5e2bbe9 into gajus:master Oct 13, 2018
@gajus
Copy link
Owner

gajus commented Oct 13, 2018

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants