Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script that checks if there are tests and docs for each rule and they are included in their corresponding "index" files. It was discussed in #366. What exactly is checked is documented in the header of the script. I added this check to pre-commit hook.
Thanks to this script I discovered that three rules have no assertions in readme and that for one rule tests were not executed. I fixed these issues.
Side note: The new post-commit hook crashes when the current branch is not in
.git/config
yet, which I think is before the push to a remote server. This crash comes from gitdown and transitively from gitinfo. Also in contributing guide there is a sentence that the documentation is built using CI but it seems that it is not true anymore (imo it was removed in this commit). I think that generating docs in CI is better approach than in post commit hook but that's just my hint.