Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for implicit exact Flow types #471

Merged
merged 1 commit into from
Apr 5, 2021
Merged

feat: add support for implicit exact Flow types #471

merged 1 commit into from
Apr 5, 2021

Conversation

mrtnzlml
Copy link
Contributor

@mrtnzlml mrtnzlml commented Mar 15, 2021

This commit adds a support for implicit exact Flow types. This is especially useful when using exact_by_default=true Flow option and migrating towards { } and { ... } syntax (Flow standard is now to use { } for strict objects and { key: value, ... } for open objects).

Closes: #467

TODO:

Copy link
Contributor

@Brianzchen Brianzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit adds a support for implicit exact Flow types. This is especially useful when using `exact_by_default=true` Flow option and migrating towards `{ }` and `{ ... }` syntax (Flow standard is now to use `{ }` for strict objects and `{ key: value, ... }` for open objects).

Closes: #467
@mrtnzlml mrtnzlml marked this pull request as ready for review March 17, 2021 13:42
@Brianzchen
Copy link
Contributor

@gajus

@Brianzchen
Copy link
Contributor

@gajus bump

@mrtnzlml
Copy link
Contributor Author

mrtnzlml commented Apr 4, 2021

Hi, is there anything I can improve in this PR to make it mergeable?

I would also like to offer my help with the maintenance of this project if needed. We are using this plugin for years and it's always been a pleasure. I would not like to see it slowly die. 😎

@gajus gajus merged commit 6d5362b into gajus:master Apr 5, 2021
@gajus
Copy link
Owner

gajus commented Apr 5, 2021

I cannot recall the reason I did not merge this the first few times it was bumped. Sorry about that.

@gajus
Copy link
Owner

gajus commented Apr 5, 2021

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 5, 2021
@mrtnzlml mrtnzlml deleted the react_readonly_implicitExactTypes branch April 5, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule 'require-readonly-react-props' not compatible with implicit exact objects
3 participants