Fix tests #68
Merged
Fix tests #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could either change arrow function expected output to match normal functions,
or some up with a nicer output in general
e.g. given:
function foo({ lorem, ipsum, dolor } : SomeType) {}
({ lorem, ipsum, dolor } : SomeType) => {}
before arrows would print:
{ lorem, ipsum, dolor }
and functions would print:
{ lorem, ipsum, dolor } : SomeType
now they both print:
{ lorem, ipsum, dolor }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
So today a bug in Babylon was fixed. Previously, the locations on function params included the type annotation, but arrow functions didn't. (which was the cause of #47)
This meant that the
getParameterNameoutput for an arrow-function param would be{ lorem, ipsum, dolor }, and normal function params would be{ lorem, ipsum, dolor }: SomeType(includes the type annotation).Now, we can either update the tests so arrow functions standardise with normal functions (
{ lorem, ipsum, dolor }: SomeType) or update the code to have the cleaner output that we previously had for arrows, but for all functions types:{ lorem, ipsum, dolor }I'd say it's a little hacky, basically getting the source for the entire param, and stripping out the source of the type annotation.