Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-returns-check don't detect implicit return #156

Closed
gabmontes opened this issue Jan 30, 2019 · 2 comments
Closed

require-returns-check don't detect implicit return #156

gabmontes opened this issue Jan 30, 2019 · 2 comments
Labels
bug released

Comments

@gabmontes
Copy link

gabmontes commented Jan 30, 2019 •
edited

image

The implicit return does not seem to be found by require-returns-check and the rule fails when it should not.

Using version 4.1.0.
@gajus
Copy link
Owner

gajus commented Jan 30, 2019

Related #148

CC @james2doyle

@gajus gajus added the bug label Jan 30, 2019
@gajus gajus closed this as completed in 3483159 Mar 15, 2019
gajus added a commit that referenced this issue Mar 15, 2019
@gajus
fix: recognize implicit return in require-returns-check (fixes #156)
b8b9692 
fix: recognize implicit return in require-returns-check (fixes #156)
@gajus
Copy link
Owner

gajus commented Mar 15, 2019

🎉 This issue has been resolved in version 4.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gajus @gabmontes