-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publicOnly
to handle more export formats
#288
Comments
As the first two items are fixed, I can take a look at the object keys, scoping and writing test cases for uncovered lines of exportparser file. Scoping likely requires more strict tracking of ECMAScript specification than the resolver does so far, to not give wrong results. |
Sounds good... Re: object keys, FWIW, while there are probably better examples, I happened to find in exploring the uncovered lines a little, that, per my example, putting a template and function in the position of a key handled a couple of those uncovered lines (now exempted from coverage)--as unusual as the latter is. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I think the most critical items are discoverable, so closing. |
The new
publicOnly
ofrequire-jsdoc
seems not to be able to handle exports of any of these forms (withesm: true
) as these fail to report missing jsdoc:export default function () {
,export default class {}
,export default () => {}
- (The first two of these anonymous defaults were giving errors, but this is now fixed.)export var a = function () {}
(export {name}
is already implemented)TSInterfaceDeclaration
(see require-jsdoc: contexts and publicOnly lead to false negatives #492)With some strange structures like the following, besides the fact of adding support, it would let us remove some
/* istanbul ignore next */
directives (see #286 , an issue interrelated with this one), but this won't pass now, and would need to support scopes (which the code comments indicate is not yet supported) and may in some cases be more complexity than its worth (e.g., parsing template properties):@Extersky
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: