-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(require-param
): check deeply destructured parameters (fixes #569)
#630
Conversation
require-param
): check deeply destructured parameters (fixes #569)
Looks great from a quick look, thank you very much! In case it will all need to be redone though, I'm a little reluctant to add much more code on top of our code until the first part of #540 might be addressed (i.e., "Where a root and grandchildren are present but not children, the fixing order is off."). Do you think this is something you could also look into? If not, I can still see about merging as it of course is better to have something working. |
Thank you for your quick response! Actually, It's my first PR in open source. So #540 seems like a difficult issue for me to solve for now... Can I try it when I have enough time? |
Ok--but as we also have an |
Of course! |
The error mentioned in issue gajus#569 also occurred in `check-param-name` rule. So I fixed.
@brettz9 |
Great work, thank you!! |
🎉 This PR is included in version 30.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #569
Check the type of destructured parameters in the require-param rule.