Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make require-returns-description accept void functions (fixes #157) #167

Merged
merged 2 commits into from
Mar 13, 2019
Merged

feat: make require-returns-description accept void functions (fixes #157) #167

merged 2 commits into from
Mar 13, 2019

Conversation

golopot
Copy link
Collaborator

@golopot golopot commented Mar 13, 2019

Fixes #157 .

If the return type is {void} or {undefined}, return description is not required.

@gajus gajus merged commit 39918c8 into gajus:master Mar 13, 2019
@gajus
Copy link
Owner

gajus commented Mar 13, 2019

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Mar 13, 2019
@eXigentCoder
Copy link

Hey there, just a quick update, it seems to still be an issue if your return type is {Promise<undefined>} or {Promise<void>}

@golopot golopot deleted the issue-157-2 branch June 26, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require-returns-description requires description even when type is undefined
3 participants