fix for issue #55

gajus · Aug 6, 2022 · 50a87ed · 50a87ed
1 parent bf4aa36
commit 50a87ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/utilities/parseProxyUrl.ts b/src/utilities/parseProxyUrl.ts
@@ -14,7 +14,8 @@ export default (url: string) => {
   }
 
   if (urlTokens.protocol !== 'http:' && urlTokens.protocol !== 'https:') {
-    throw new UnexpectedStateError('Unsupported `GLOBAL_AGENT.HTTP_PROXY` or `GLOBAL_AGENT.HTTPS_PROXY` configuration value: URL protocol must be "http:" or "https:".');
+    const errorMessage = 'Unsupported `GLOBAL_AGENT.HTTP_PROXY` or `GLOBAL_AGENT.HTTPS_PROXY` configuration value: URL protocol must be "http:" or "https:".';
+    throw new UnexpectedStateError(errorMessage);
   }
 
   let port = 80;

diff --git a/test/global-agent/utilities/parseProxyUrl.ts b/test/global-agent/utilities/parseProxyUrl.ts
@@ -13,12 +13,12 @@ test('extracts authorization', (t) => {
   t.is(parseProxyUrl('http://foo:bar@0.0.0.0').authorization, 'foo:bar');
 });
 
-test('throws an error if protocol is not "http:"', (t) => {
+test('throws an error if protocol is not "http:" or "https:"', (t) => {
   const error = t.throws(() => {
-    parseProxyUrl('https://0.0.0.0:3000');
+    parseProxyUrl('ws://0.0.0.0:3000');
   });
 
-  t.is(error.message, 'Unsupported `GLOBAL_AGENT.HTTP_PROXY` configuration value: URL protocol must be "http:".');
+  t.is(error.message, 'Unsupported `GLOBAL_AGENT.HTTP_PROXY` or `GLOBAL_AGENT.HTTPS_PROXY` configuration value: URL protocol must be "http:" or "https:".');
 });
 
 test('throws an error if query is present', (t) => {