Fix nested array deconstruction

gajus · Mar 29, 2020 · 4930e1c · 4930e1c
1 parent 309ea5b
commit 4930e1c
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 2 deletions.
diff --git a/src/deflate.js b/src/deflate.js
@@ -26,7 +26,7 @@ const deflate = (node: Object, index: Object, path: $ReadOnlyArray<string>) => {
 
   const fieldNames = Object.keys(node);
 
-  const result = {};
+  const result = Array.isArray(node) ? [] : {};
 
   for (const fieldName of fieldNames) {
     const value = node[fieldName];

diff --git a/src/inflate.js b/src/inflate.js
@@ -22,7 +22,7 @@ const inflate = (node: Object, index: Object, path: $ReadOnlyArray<string>) => {
 
   const fieldNames = Object.keys(node);
 
-  const result = {};
+  const result = Array.isArray(node) ? [] : {};
 
   for (const fieldName of fieldNames) {
     const value = node[fieldName];

diff --git a/test/deflate.js b/test/deflate.js
@@ -177,3 +177,33 @@ test('does not deconstruct an array of string', (t) => {
     }
   });
 });
+
+test('does not deconstruct a nested array', (t) => {
+  const response = {
+    data: {
+      __typename: 'foo',
+      names: [
+        [
+          'foo',
+          'bar1',
+          'bar2'
+        ]
+      ]
+    }
+  };
+
+  const deflatedResponse = deflate(response);
+
+  t.deepEqual(deflatedResponse, {
+    data: {
+      __typename: 'foo',
+      names: [
+        [
+          'foo',
+          'bar1',
+          'bar2'
+        ]
+      ]
+    }
+  });
+});
diff --git a/test/inflate.js b/test/inflate.js
@@ -131,3 +131,33 @@ test('does not deconstruct an array of string', (t) => {
     }
   });
 });
+
+test('does not deconstruct a nested array', (t) => {
+  const response = {
+    data: {
+      __typename: 'foo',
+      names: [
+        [
+          'foo',
+          'bar1',
+          'bar2'
+        ]
+      ]
+    }
+  };
+
+  const inflatedResponse = inflate(response);
+
+  t.deepEqual(inflatedResponse, {
+    data: {
+      __typename: 'foo',
+      names: [
+        [
+          'foo',
+          'bar1',
+          'bar2'
+        ]
+      ]
+    }
+  });
+});