Skip to content

Commit

Permalink
refactor: implement review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
JohannesLamberts committed Dec 23, 2020
1 parent 0c09a01 commit 23f2e16
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 81 deletions.
10 changes: 1 addition & 9 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,7 @@
],
"extends": [
"canonical",
"eslint:recommended",
"plugin:@typescript-eslint/recommended"
"canonical/typescript"
],
"settings": {
"import/resolver": {
"node": {
"extensions": [".js", ".ts", ".d.ts"]
}
}
},
"root": true
}
8 changes: 4 additions & 4 deletions src/factories/createLightship.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const log = Logger.child({
namespace: 'factories/createLightship',
});

const defaultConfiguration = {
const defaultConfiguration: Configuration = {
detectKubernetes: true,
gracefulShutdownTimeout: 60_000,
port: 9_000,
Expand Down Expand Up @@ -112,7 +112,7 @@ export default (userConfiguration?: ConfigurationInput): Lightship => {
server,
});

app.get('/health', (request, response) => {
app.get('/health', (_request, response) => {
if (serverIsShuttingDown) {
response.status(500).send(SERVER_IS_SHUTTING_DOWN);
} else if (serverIsReady) {
Expand All @@ -122,15 +122,15 @@ export default (userConfiguration?: ConfigurationInput): Lightship => {
}
});

app.get('/live', (request, response) => {
app.get('/live', (_request, response) => {
if (serverIsShuttingDown) {
response.status(500).send(SERVER_IS_SHUTTING_DOWN);
} else {
response.send(SERVER_IS_NOT_SHUTTING_DOWN);
}
});

app.get('/ready', (request, response) => {
app.get('/ready', (_request, response) => {
if (serverIsReady) {
response.send(SERVER_IS_READY);
} else {
Expand Down
5 changes: 4 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
export {
default as createLightship,
} from './factories/createLightship';
export * from './types';
export type {
Lightship,
ConfigurationInput,
} from './types';
89 changes: 22 additions & 67 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,71 +1,26 @@
{
"compilerOptions": {
/* Visit https://aka.ms/tsconfig.json to read more about this file */

/* Basic Options */
// "incremental": true, /* Enable incremental compilation */
"target": "esnext", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */
// "lib": [], /* Specify library files to be included in the compilation. */
// "allowJs": true, /* Allow javascript files to be compiled. */
// "checkJs": true, /* Report errors in .js files. */
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
"declaration": true, /* Generates corresponding '.d.ts' file. */
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
"sourceMap": true, /* Generates corresponding '.map' file. */
// "outFile": "./", /* Concatenate and emit output to single file. */
"outDir": "./dist", /* Redirect output structure to the directory. */
"rootDir": "./src", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
// "composite": true, /* Enable project compilation */
// "tsBuildInfoFile": "./", /* Specify file to store incremental compilation information */
// "removeComments": true, /* Do not emit comments to output. */
// "noEmit": true, /* Do not emit outputs. */
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
"isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */

/* Strict Type-Checking Options */
"strict": true, /* Enable all strict type-checking options. */
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
// "strictNullChecks": true, /* Enable strict null checks. */
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
// "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */

/* Additional Checks */
// "noUnusedLocals": true, /* Report errors on unused locals. */
// "noUnusedParameters": true, /* Report errors on unused parameters. */
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
// "noUncheckedIndexedAccess": true, /* Include 'undefined' in index signature results */

/* Module Resolution Options */
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
// "typeRoots": [], /* List of folders to include type definitions from. */
// "types": [], /* Type declaration files to be included in compilation. */
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
"esModuleInterop": true, /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */

/* Source Map Options */
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */

/* Experimental Options */
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */

/* Advanced Options */
"skipLibCheck": true, /* Skip type checking of declaration files. */
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
"allowSyntheticDefaultImports": true,
"declaration": true,
"esModuleInterop": true,
"lib": [
"es2020"
],
"module": "commonjs",
"moduleResolution": "node",
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"outDir": "dist",
"skipLibCheck": true,
"strict": true,
"target": "es2020"
},
"exclude": ["./test"]
"exclude": [
"dist",
"node_modules"
],
"include": [
"src"
]
}

0 comments on commit 23f2e16

Please sign in to comment.