Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript declarations #29

Closed
JohannesLamberts opened this issue Dec 8, 2020 · 2 comments · Fixed by #30
Closed

Typescript declarations #29

JohannesLamberts opened this issue Dec 8, 2020 · 2 comments · Fixed by #30
Labels
enhancement New feature or request released

Comments

@JohannesLamberts
Copy link
Contributor

Hi there 👋

It would be awesome if you could expose typescript declarations.
I saw that the codebase is already typed using flow.

If you'd be interested into converting the codebase to TS I look into opening a PR.

If not - maybe its possible to generated d.ts files from the flow typings? 🤔
@gajus
Copy link
Owner

gajus commented Dec 8, 2020

I am open to converting to TS.

@gajus gajus added the enhancement New feature or request label Dec 8, 2020
@JohannesLamberts JohannesLamberts mentioned this issue Dec 21, 2020
Merged
@gajus gajus closed this as completed in #30 Dec 23, 2020
@gajus
Copy link
Owner

gajus commented Dec 23, 2020

🎉 This issue has been resolved in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate to typescript
2 participants
@gajus @JohannesLamberts