-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to typescript #30
Conversation
the untyped 'promise-deferred' leads to tsc errors, but otherwise look good so far. |
@gajus 'promise-deferred' is currently missing types. I removed the dependency as the same can be archived with little code, also reducing dependencies. If you dislike the change I could re-insert the module and either add types inside this repo (they don't need to be exported, since the I'm looking forward to your review 🙂 |
ahhh, now nyc fails. Otherwise, the tests are green. |
Pull Request Test Coverage Report for Build 130
💛 - Coveralls |
Pull Request Test Coverage Report for Build 132
💛 - Coveralls |
@gajus thanks for the quick feedback. I don't know if you prefer to resolve the discussions. I went ahead and resolved them after my commit. I also noted that I accidentally removed the I compared the dist file before and after the migration to make sure everything is ok. The only real difference apart from .d.ts instead of .flow files is the change of promise-deferred. |
Thank you |
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #29