Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to typescript #30

Merged
merged 5 commits into from
Dec 23, 2020
Merged

feat: migrate to typescript #30

merged 5 commits into from
Dec 23, 2020

Conversation

JohannesLamberts
Copy link
Contributor

closes #29

@JohannesLamberts JohannesLamberts changed the title feat: migrate to typescript WIP: feat: migrate to typescript Dec 21, 2020
@JohannesLamberts
Copy link
Contributor Author

the untyped 'promise-deferred' leads to tsc errors, but otherwise look good so far.

@JohannesLamberts
Copy link
Contributor Author

@gajus 'promise-deferred' is currently missing types. I removed the dependency as the same can be archived with little code, also reducing dependencies.

If you dislike the change I could re-insert the module and either add types inside this repo (they don't need to be exported, since the Deferred is not public) - or add the types to DefinitelyTyped as suggested in ljharb/promise-deferred#9.

I'm looking forward to your review 🙂

@JohannesLamberts JohannesLamberts changed the title WIP: feat: migrate to typescript feat: migrate to typescript Dec 22, 2020
@JohannesLamberts
Copy link
Contributor Author

JohannesLamberts commented Dec 22, 2020

ahhh, now nyc fails. Otherwise, the tests are green.
I'll try to look into that tomorrow.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 130

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 91.327%

Totals Coverage Status
Change from base Build 126: 0.8%
Covered Lines: 139
Relevant Lines: 148

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 23, 2020

Pull Request Test Coverage Report for Build 132

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 91.327%

Totals Coverage Status
Change from base Build 126: 0.8%
Covered Lines: 139
Relevant Lines: 148

💛 - Coveralls

src/index.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
@JohannesLamberts
Copy link
Contributor Author

@gajus thanks for the quick feedback. I don't know if you prefer to resolve the discussions. I went ahead and resolved them after my commit.

I also noted that I accidentally removed the --source-maps option and forgot to remove @babel/plugin-transform-flow-strip-types. Both have been adressed with the two latest commits.

I compared the dist file before and after the migration to make sure everything is ok. The only real difference apart from .d.ts instead of .flow files is the change of promise-deferred.

@gajus gajus merged commit 56f1c04 into gajus:master Dec 23, 2020
@gajus
Copy link
Owner

gajus commented Dec 23, 2020

Thank you

@gajus
Copy link
Owner

gajus commented Dec 23, 2020

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Dec 23, 2020
@JohannesLamberts JohannesLamberts deleted the feat/migrate-flow-to-ts branch December 29, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript declarations
3 participants