feat: Update fastify to expose API for HEAD requests.
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables a fastify config to enable `HEAD` requests. Readiness and liveness checks should respond correctly to `HEAD` requests since only the status codes are usually relevant for checking the status of services via tools like curl. Eg: https://hub.docker.com/r/stefanevinance/wait-for-200/ https://github.com/stefan-evinance/wait-for-200 Tests have been updated to verify this behaviour.
|
@gajus This is currently blocking me from using the latest version of lightship. If merged, could you consider releasing a minor or patch revision? |
|
@gajus Any update on this please? |
|
Sometimes notifications get lost :-( Looking at this now |
|
🎉 This issue has been resolved in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables a fastify config to enable
HEADrequests. Readiness and liveness checks should respond correctly toHEADrequests since only the status codes are usually relevant for checking the status of services via tools like curl.Eg:
https://hub.docker.com/r/stefanevinance/wait-for-200/
https://github.com/stefan-evinance/wait-for-200
Tests have been updated to verify this behaviour.