Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for --comma-break #8

Closed
karlhorky opened this issue Nov 28, 2020 · 8 comments
Closed

Option for --comma-break #8

karlhorky opened this issue Nov 28, 2020 · 8 comments

Comments

@karlhorky
Copy link

Hi @gajus,

Would it be possible to add an option for the --comma-break option?

With --comma-break

Screen Shot 2020-11-28 at 16 34 18

Without --comma-break

Screen Shot 2020-11-28 at 16 32 09 16 34 47

@gajus
Copy link
Owner

gajus commented Nov 28, 2020

PR is welcome.

@richeyryan-geowox
Copy link
Contributor

Hey @gajus,

So since my PR was merged, would it be possible to get a release for NPM?

Also could the version in eslint-plugin-sql be updated? I'm happy to make the PR once the new version of pg-formatter is pushed to NPM

@gajus
Copy link
Owner

gajus commented Jun 14, 2021

Releases are automated. It looks like not all tests are passing:

https://travis-ci.com/github/gajus/pg-formatter/jobs/513308340

@richeyryan-geowox
Copy link
Contributor

I noticed that alright when I forked the repo. Some test unrelated to what I added was failing. I can take a look at it to unblock the release.

@richeyryan-geowox
Copy link
Contributor

I tried figuring out that failing test but I honestly couldn't figure out what the anonymize option is meant to do. I ran a few examples through the pgFormatter website and I couldn't pin down what effect anonymize was having. If you could clarify for me I'd be happy to take another look.

@nponiros
Copy link
Contributor

nponiros commented Oct 29, 2021

I had a look at the failing test. The problem seems to be the pg-formatter version used (looks like anonymize is broken in v5.x). Using the latest version the test fails. Using v4.4 the test doesn't fail. V4.4 was the latest version the last time this package was release from what I can tell. @gajus it is probably a good idea to specify the version in the build-pg-formatter command. I can open a PR to force v4.4 and maybe as a second step you could release a new version of this package with v5.1 which fixes a bunch of bugs from what I can tell.

I opened an issue darold/pgFormatter#265

@gajus
Copy link
Owner

gajus commented Nov 1, 2021

Could you please update your PR to lock v4.4 version?

@nponiros
Copy link
Contributor

nponiros commented Nov 3, 2021

Done

@gajus gajus closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants