-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for --comma-break
#8
Comments
PR is welcome. |
Hey @gajus, So since my PR was merged, would it be possible to get a release for NPM? Also could the version in eslint-plugin-sql be updated? I'm happy to make the PR once the new version of pg-formatter is pushed to NPM |
Releases are automated. It looks like not all tests are passing: https://travis-ci.com/github/gajus/pg-formatter/jobs/513308340 |
I noticed that alright when I forked the repo. Some test unrelated to what I added was failing. I can take a look at it to unblock the release. |
I tried figuring out that failing test but I honestly couldn't figure out what the |
I had a look at the failing test. The problem seems to be the pg-formatter version used (looks like anonymize is broken in v5.x). Using the latest version the test fails. Using v4.4 the test doesn't fail. V4.4 was the latest version the last time this package was release from what I can tell. @gajus it is probably a good idea to specify the version in the I opened an issue darold/pgFormatter#265 |
Could you please update your PR to lock v4.4 version? |
Done |
Hi @gajus,
Would it be possible to add an option for the
--comma-break
option?With
--comma-break
Without
--comma-break
The text was updated successfully, but these errors were encountered: