fix: continue to attempt scheduling tasks that breach concurrency

gajus · Dec 3, 2020 · 6d209a5 · 6d209a5
1 parent 3e33b8e
commit 6d209a5
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/factories/createPlanton.ts b/src/factories/createPlanton.ts
@@ -150,7 +150,7 @@ const createPlanton = (configuration: PlantonConfiguration): Planton => {
           const activeTaskInstructions = await getActiveTaskInstructions(inputTask.name);
 
           if (activeTaskInstructions.length >= concurrency) {
-            break;
+            continue;
           }
 
           let taskInstructions: TaskInstruction[];

diff --git a/test/planton/factories/createPlanton.ts b/test/planton/factories/createPlanton.ts
@@ -595,3 +595,31 @@ test('scheduler executions are evenly distributed', async (t) => {
 
   await planton.terminate();
 });
+
+test('continues to attempt scheduling tasks that breach concurrency', async (t) => {
+  const getActiveTaskInstructions = sinon
+    .stub()
+    .returns(['1']);
+
+  const planton = createPlanton({
+    getActiveTaskInstructions,
+    tasks: [
+      {
+        concurrency: 1,
+        delay: () => {
+          return 10;
+        },
+        name: 'foo',
+        schedule: () => {
+          throw new Error('Should not be called.');
+        },
+      },
+    ],
+  });
+
+  await delay(100);
+
+  t.true(getActiveTaskInstructions.callCount > 3);
+
+  await planton.terminate();
+});