Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on lodash and pluralize #15

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 29, 2016

I only now realized that these are dependencies. In general we try to pick projects with as least dependencies as possible for our Ecosystem packages. I don't think Lodash dependency is justified here, as it increases bundle size for a few utility functions.

Unfortunately I couldn't figure out how to fix the linter to not complain about usage of built-in functions. I understand if you don't want to take this, but unfortunately we can't officially recommend a package that brings in the whole Lodash for the sake of combineReducers().

@gajus
Copy link
Owner

gajus commented Jan 29, 2016

Ignore the merge conflicts – did not see the PR before removing the pluralize dependency. Will fix the merge conflicts myself.

@gajus gajus merged commit 18cf8b2 into gajus:master Jan 29, 2016
@gajus
Copy link
Owner

gajus commented Jan 29, 2016

Thank you for the PR @gaearon.

@gajus
Copy link
Owner

gajus commented Jan 29, 2016

Version 3.0.2 released and incorporates all these changes.

@mxstbr
Copy link

mxstbr commented Jan 29, 2016

Fresh install of 3.0.2, getting the following error:

/~/redux-immutable/dist/combineReducers.js
Module not found: Error: Cannot resolve module 'lodash/forEach'

EDIT: #17

@gaearon gaearon deleted the remove-lodash branch January 29, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants