feat: do not execute update query if value bindings object has no keys

gajus · Jul 27, 2019 · eccc31d · eccc31d
1 parent 7f2baa6
commit eccc31d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/routines/update.js b/src/routines/update.js
@@ -20,6 +20,10 @@ export default async (
   // eslint-disable-next-line flowtype/no-weak-types
   booleanExpressionValues: Object = null
 ) => {
+  if (Object.keys(namedValueBindings).length === 0) {
+    return;
+  }
+
   const assignmentList = sql.assignmentList(namedValueBindings);
 
   if (booleanExpressionValues) {

diff --git a/test/slonik-utilities/routines/update.js b/test/slonik-utilities/routines/update.js
@@ -18,6 +18,18 @@ const createConnection = () => {
   return connection;
 };
 
+test('does not execute UPDATE query if named value bindings object has no keys', async (t) => {
+  const connection = createConnection();
+
+  await update(
+    connection,
+    'foo',
+    {}
+  );
+
+  t.is(connection.query.callCount, 0);
+});
+
 test('executes UPDATE query without WHERE condition (single column)', async (t) => {
   const connection = createConnection();