perf: inline large loops

gajus · Jun 14, 2019 · 0cb7db0 · 0cb7db0
1 parent b180ebb
commit 0cb7db0
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 11 deletions.
diff --git a/.babelrc b/.babelrc
@@ -8,6 +8,7 @@
   },
   "plugins": [
     "transform-export-default-name",
+    "macros",
     "@babel/transform-flow-strip-types"
   ],
   "presets": [

diff --git a/package.json b/package.json
@@ -43,6 +43,7 @@
     "flow-copy-source": "^2.0.6",
     "gitdown": "^2.5.7",
     "husky": "^2.3.0",
+    "inline-loops.macro": "^1.0.3",
     "nyc": "^14.1.1",
     "semantic-release": "^15.13.12",
     "sinon": "^7.3.2"

diff --git a/src/connectionMethods/anyFirst.js b/src/connectionMethods/anyFirst.js
@@ -1,5 +1,8 @@
 // @flow
 
+import {
+  map
+} from 'inline-loops.macro';
 import {
   createQueryId
 } from '../utilities';
@@ -34,7 +37,7 @@ const anyFirst: InternalQueryAnyFirstFunctionType = async (log, connection, clie
 
   const firstColumnName = keys[0];
 
-  return rows.map((row) => {
+  return map(rows, (row) => {
     return row[firstColumnName];
   });
 };

diff --git a/src/connectionMethods/manyFirst.js b/src/connectionMethods/manyFirst.js
@@ -1,5 +1,8 @@
 // @flow
 
+import {
+  map
+} from 'inline-loops.macro';
 import {
   createQueryId
 } from '../utilities';
@@ -36,7 +39,7 @@ const manyFirst: InternalQueryManyFirstFunctionType = async (log, connection, cl
 
   const firstColumnName = keys[0];
 
-  return rows.map((row) => {
+  return map(rows, (row) => {
     return row[firstColumnName];
   });
 };

diff --git a/src/routines/executeQuery.js b/src/routines/executeQuery.js
@@ -1,5 +1,8 @@
 // @flow
 
+import {
+  map
+} from 'inline-loops.macro';
 import serializeError from 'serialize-error';
 import {
   getStackTrace
@@ -56,14 +59,13 @@ export default async (
   if (clientConfiguration.captureStackTrace) {
     const callSites = await getStackTrace();
 
-    stackTrace = callSites
-      .map((callSite) => {
-        return {
-          columnNumber: callSite.columnNumber,
-          fileName: callSite.fileName,
-          lineNumber: callSite.lineNumber
-        };
-      });
+    stackTrace = map(callSites, (callSite) => {
+      return {
+        columnNumber: callSite.columnNumber,
+        fileName: callSite.fileName,
+        lineNumber: callSite.lineNumber
+      };
+    });
   }
 
   const queryId = inheritedQueryId || createQueryId();
@@ -176,7 +178,7 @@ export default async (
         const fields = result.fields;
 
         // eslint-disable-next-line no-loop-func
-        const rows: $ReadOnlyArray<QueryResultRowType> = result.rows.map((row) => {
+        const rows: $ReadOnlyArray<QueryResultRowType> = map(result.rows, (row) => {
           return transformRow(executionContext, actualQuery, row, fields);
         });