Change query retry handling #308
Conversation
Move transaction retry handling to the transaction and nestedTransaction methods and change it so that the handler function is called again instead of just replaying the queries that are part of the transaction. Fixes gajus#163. Add a second parameter to the transaction method to allow users to define a retry limit per transaction. If a retry limit is given for a transaction then the global defined retry limit for transactions is ignored. Change executeQuery so that it retries individual queries that failed with a transaction rollback error. Only queries that are not part of a transaction are retried. The number of times a query is retried is specified by the global queryRetryLimit configuration. Fixes gajus#176. The above change also fixes gajus#196 since the transactionQueries array no longer exists.
|
A few things to note: The blocking/unblocking behaviour for transactions is now different than before. Now we unblock before retrying a transaction. Before the unblock took place after the retry. I don't fully understand the reason for the blocking/unblocking so I'm not sure if this causes any issues. With the way I implemented the retry mechanism for a single query and transaction the user will see the transaction rollback error if the query/transaction fails despite the retries. Before the user would get an UnexpectedState error. I assumed that this was a bug. Also before the queries were retried until the limit was reached and the result of the last retry was return. I also assumed that this was a bug and now the retry function returns as soon as a query succeeds. The way I implemented the transaction retry a nested transaction is retried until it reaches its limit and in case the transaction rollback error persist the parent transaction is retried until its limit. I don't know if this is such a good idea. Perhaps it would be better to not retry nested transactions and let the parent transaction do the retry. |
|
@nponiros This is really awesome contribution. Thank you for taking time to put it together. I am releasing it as a breaking change. |
|
🎉 This PR is included in version 25.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Move transaction retry handling to the transaction and nestedTransaction
methods and change it so that the handler function is called again
instead of just replaying the queries that are part of the transaction.
Fixes #163.
Add a second parameter to the transaction method to allow users to
define a retry limit per transaction. If a retry limit is given for a
transaction then the global defined retry limit for transactions is
ignored.
Change executeQuery so that it retries individual queries that failed
with a transaction rollback error. Only queries that are not part of a
transaction are retried. The number of times a query is retried is
specified by the global queryRetryLimit configuration. Fixes #176.
The above change also fixes #196 since the transactionQueries array no
longer exists.