Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zod validation #369

Closed
wants to merge 19 commits into from
Closed

feat: add zod validation #369

wants to merge 19 commits into from

Conversation

gajus
Copy link
Owner

@gajus gajus commented Aug 4, 2022 •
edited

This PR most likely supersedes #367

@gajus gajus temporarily deployed to release August 4, 2022 20:17 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:17 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:17 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:17 Inactive
@gajus gajus mentioned this pull request Aug 4, 2022
Closed
@gajus gajus temporarily deployed to release August 4, 2022 20:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus marked this pull request as ready for review August 4, 2022 20:42
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 20:42 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:22 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:22 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:33 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:33 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:33 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:33 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:37 Inactive
@gajus gajus temporarily deployed to release August 4, 2022 21:37 Inactive
mmkal
mmkal reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@mmkal mmkal left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this doesn't affect end-users as much - but I think the zod types can be abstracted away more.

src/factories/createSqlTag.ts Show resolved Hide resolved
src/factories/createSqlTag.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
@gajus
Copy link
Owner Author

gajus commented Aug 4, 2022

Happy to accept it as an improvement, but I don't necessarily see major benefit to loose coupling. Zod is a leading choice for this purpose.

@gajus gajus mentioned this pull request Aug 5, 2022
Closed
@gajus gajus changed the title Add zod validation (backwards compatible) feat: add zod validation Aug 5, 2022
@gajus gajus temporarily deployed to release August 5, 2022 00:47 Inactive
@gajus gajus temporarily deployed to release August 5, 2022 00:47 Inactive
@gajus gajus temporarily deployed to release August 5, 2022 00:47 Inactive
@gajus gajus temporarily deployed to release August 5, 2022 00:47 Inactive
@gajus gajus temporarily deployed to release August 5, 2022 00:47 Inactive
mmkal
mmkal reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@mmkal mmkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a hopefully less invasive implementation of this, that doesn't affect the existing types or functionality.

src/factories/createSqlTag.ts Show resolved Hide resolved
src/routines/executeQuery.ts Show resolved Hide resolved
mmkal added a commit to mmkal/slonik that referenced this pull request Aug 5, 2022
@mmkal
add all tests from gajus#369
c6b8724
mmkal added a commit to mmkal/slonik that referenced this pull request Aug 5, 2022
@mmkal
add tests deleted in gajus#369
5e851a7
@mmkal mmkal mentioned this pull request Aug 5, 2022
Closed
@gajus gajus mentioned this pull request Aug 5, 2022
Merged
@gajus gajus closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkal mmkal mmkal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gajus @mmkal