Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making xml property public so we can access the SimpleXML object directly #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisnharvey
Copy link
Contributor

If someone is using a custom template, such as Secure Trading's 3Dsecure implementation, then the data in the Response object is not enough to complete the payment process.

I have just changed the visibility of the $xml property to public so we can access the SimpleXML object directly to get the data we need.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.71% when pulling a83b231 on chrisnharvey:patch-1 into ac20750 on gajus:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.71% when pulling a83b231 on chrisnharvey:patch-1 into ac20750 on gajus:master.

@gajus
Copy link
Owner

gajus commented Feb 15, 2015

I am not happy with exposing the entire SimpleXML object. (This creates a direct dependency between SecureTrading XML feed and library API) I would prefer an abstraction that would extract domain specific data/state. I have not worked with 3Dsecure, but if I will, I will add the missing functionality. Alternatively, contributions are welcome, of course.

@chrisnharvey
Copy link
Contributor Author

That makes sense. Do you have any suggestions for a possible abstraction? I'm happy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants