Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Shared drawing logic #162

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented Apr 24, 2021

This PR unifies the logic to draw horizontal borders, content rows, and the entire table in one place.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 321

  • 31 of 31 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 349
Relevant Lines: 349

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 24, 2021

Pull Request Test Coverage Report for Build 322

  • 29 of 29 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 349
Relevant Lines: 349

💛 - Coveralls

@nam-hle nam-hle marked this pull request as ready for review April 24, 2021 07:28
@gajus gajus merged commit 366e380 into gajus:master Apr 24, 2021
@nam-hle nam-hle deleted the refactor-drawing branch April 24, 2021 14:10
@gajus
Copy link
Owner

gajus commented Apr 27, 2021

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants