Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Rename variables/files #164

Merged
merged 3 commits into from
Apr 25, 2021
Merged

[refactor] Rename variables/files #164

merged 3 commits into from
Apr 25, 2021

Conversation

nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented Apr 25, 2021 •
edited

  • Rename variable/file names with trailing index, or containing span, maximum:
    • calculateCellWidthIndex.ts → calculateCellWidths.ts
    • calculateMaximumColumnWidthIndex.ts → calculateColumnWidths.ts
    • calculateRowHeightIndex.ts → calculateRowHeights.ts
  • Rename index parameters (and index0, index1, ...) in forEach, map callbacks to be more meaningful one
  • Rename variables name value to proper name

@coveralls
Copy link

coveralls commented Apr 25, 2021 •
edited

Pull Request Test Coverage Report for Build 327

  • 76 of 76 (100.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 325: 0.0%
Covered Lines: 342
Relevant Lines: 342
💛 - Coveralls

@nam-hle nam-hle changed the title [refactor] Remove unnecessary words [refactor] Rename variables/files Apr 25, 2021
@nam-hle nam-hle marked this pull request as ready for review April 25, 2021 06:24
@gajus gajus merged commit 8148dde into gajus:master Apr 25, 2021
@nam-hle nam-hle deleted the refactor-width-height branch April 25, 2021 23:55
@gajus
Copy link
Owner

gajus commented Apr 27, 2021

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nam-hle @coveralls @gajus