[refactor] Consistency schema and typing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityking
reviewed
Apr 25, 2021
| @@ -7,10 +7,6 @@ import type { | |||
| * Produces an array of values that describe the largest value length (width) in every column. | |||
| */ | |||
| export default (rows: Row[]): number[] => { | |||
| if (!rows[0]) { | |||
There was a problem hiding this comment.
Isn't this code run on the data, not the config?
There was a problem hiding this comment.
Yes. On data. But it is checked in validateTableData.ts.
nam-hle
force-pushed
the
consistent-schema
branch
from
0a6b926
to
f06e203
Compare
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
columnDefaultandcolumnCountare required in API interfaces but not in the schema. This PR makes it requirable, the errors will be thrown in validating step instead of processing one.The remain difference between typing and schema is about
streamConfig.columnDefault.width.Also, remove row assertion because it already checks in
validateTableData.tsfile.