Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing relative paths with absolute ones in generated critical CSS #33

Closed
wants to merge 3 commits into from
Closed

Conversation

amorphine
Copy link

Discussing here
I'm not an experienced js-developer but I think the code could be usefull to enspire you to release the most reliable fix on your own.
It replaces relative paths with absolute ones based on css file location.
Thanks

@gajus
Copy link
Owner

gajus commented Oct 10, 2017

Without the test cases it is not clear what the code is doing.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 87.156% when pulling d039432 on amorphine:feature into e6ecc83 on gajus:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 87.156% when pulling d039432 on amorphine:feature into e6ecc83 on gajus:master.

Absolute path contains path only
@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+0.3%) to 90.367% when pulling acb15b2 on amorphine:feature into e6ecc83 on gajus:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.367% when pulling 6c02a22 on amorphine:feature into e6ecc83 on gajus:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.367% when pulling 6c02a22 on amorphine:feature into e6ecc83 on gajus:master.

@amorphine amorphine closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants