feat: use get-url-proxy for better proxy environment detection

use get-url-proxy for better proxy environment detection

.gitignore

@@ -9,3 +9,4 @@ node_modules
 !.gitignore
 !.npmignore
 !.travis.yml
+package-lock.json

README.md

@@ -100,7 +100,12 @@ type fetch = (url: string, configuration?: UserConfigurationType) => Promise<Res
 
 ### HTTP proxy
 
-Uses `HTTP_PROXY` (`http://host:port`) environment variable value to configure HTTP proxy.
+Uses `PROTOCOL_PROXY` environment variable value to configure HTTP(S) proxy and supports `NO_PROXY` exclusions.
+
+```
+export NO_PROXY=".localdomain,192.168.1."
+export HTTP_PROXY="http://host:port"
+```
 
 > Note: You must also configure `NODE_TLS_REJECT_UNAUTHORIZED=0`.
 > This is a lazy workaround to enable the proxy to work with TLS.

package.json

@@ -14,6 +14,7 @@
     "bluefeather": "^2.7.0",
     "es6-error": "^4.0.2",
     "form-data": "^2.3.1",
+    "get-url-proxy": "^1.1.2",
     "http-proxy-agent": "^2.0.0",
     "https-proxy-agent": "^2.1.0",
     "node-fetch": "^2.0.0-alpha.5",
@@ -72,5 +73,5 @@
     "precommit": "npm run lint && npm run test && npm run build",
     "test": "NODE_ENV=development nyc --reporter=text ava --verbose --serial"
   },
-  "version": "1.0.0"
+  "version": "1.0.1"
 }

src/index.js

@@ -22,6 +22,7 @@ import {
 import FormData from 'form-data';
 import HttpProxyAgent from 'http-proxy-agent';
 import HttpsProxyAgent from 'https-proxy-agent';
+import getProxy from 'get-url-proxy/cached';
 import Logger from './Logger';
 import type {
   ConfigurationType,
@@ -100,17 +101,18 @@ const createConfiguration = async (url: string, userConfiguration: UserConfigura
   }
 
   let agent;
+  const proxy = getProxy(url);
 
-  if (process.env.HTTP_PROXY) {
-    log.debug('using proxy %s', process.env.HTTP_PROXY);
+  if (proxy) {
+    log.debug('using proxy %s', proxy);
 
     if (process.env.NODE_TLS_REJECT_UNAUTHORIZED !== '0') {
       throw new Error('Must configure NODE_TLS_REJECT_UNAUTHORIZED.');
     }
 
     const AgentConstructor = url.toLowerCase().startsWith('https://') ? HttpsProxyAgent : HttpProxyAgent;
 
-    agent = new AgentConstructor(process.env.HTTP_PROXY);
+    agent = new AgentConstructor(proxy);
   }
 
   const host = getHost(url);