Add getSphericalProperties function for 360 videos #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function returns an object. When a 360 video is loaded, the object has values like so:
```json
{
"fov": 100.00004285756798
"pitch": 0
"roll": 0
"yaw": 0
}
```
See: https://developers.google.com/youtube/iframe_api_reference#Spherical_Video_Controls
resistdesign
approved these changes
Jan 11, 2022
resistdesign
requested changes
Jan 11, 2022
|
@gajus the build failure seems unrelated to the commit but I'm not sure. |
|
@gajus thank you for the rapid response! I've added a further function definition and added the typing's as suggested. Thank you. |
|
@resistdesign I have raised another PR that addresses the issues with the Jenkins build. See #87 If that gets approved, I'll merge into this PR. 👍 |
|
@zymotik ok, build fix is merged! Now you just need to update this branch and resolve the conflicts and then it should be good!!! |
|
@resistdesign Thank you so much for getting this PR through so quickly! 🙇♂️ |
|
@gajus Please can you help us with a release of this new version? I am not sure on how to do this. |
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function returns an object. When a 360 video is loaded, the object has values like so:
{ "fov": 100.00004285756798 "pitch": 0 "roll": 0 "yaw": 0 }See: https://developers.google.com/youtube/iframe_api_reference#Spherical_Video_Controls