Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add RwClient #1016

Merged
merged 3 commits into from Apr 13, 2022
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 13, 2022

Motivation

Add a Provider that uses a different client for sending tx.

Solution

Wrap two clients but only the write client for ["eth_sendTransaction", "eth_sendRawTransaction"]

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst
Copy link
Owner

gakonst commented Mar 13, 2022

What would be an example use case of such a client? One would be Flashbots RPC + , anything else in mind?

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 13, 2022

What would be an example use case of such a client? One would be Flashbots RPC + , anything else in mind?

yes, this is what I had in mind, not really elaborated, but maybe useful as a starting point

@meetmangukiya
Copy link
Contributor

Hi @mattsse, can we get this merged?

@gakonst
Copy link
Owner

gakonst commented Apr 13, 2022

@meetmangukiya i'm supportive FWIW, do you also mind sharing your use case?

@mattsse needs rebase but shoujdl be good otherwise

@meetmangukiya
Copy link
Contributor

My use case is also Flashbots RPC

@mattsse
Copy link
Collaborator Author

mattsse commented Apr 13, 2022

rebased

@gakonst gakonst merged commit 02ad93a into gakonst:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants