Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TryFrom String reference for http provider #1084

Merged
merged 1 commit into from Mar 27, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 27, 2022

Motivation

This is useful because

let url = format!("...");
let provider = Provider::try_from(&url);

does not work, we can also can't use TryFrom<T:AsRef<str>> because of some blanket conflicting impl in rust core that does not allow this.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit df855b0 into gakonst:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants