feat(solc): pass compile time to reporter #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
defer review here to @mattsse altho looks good at a high level |
|
@ecmendenhall is this still a draft / you got more you wanna do on it, or should we consider merging here and in foundry? Thanks for the work! |
|
@gakonst OK to merge if it looks good to you! I was gonna check in on whether I should update the changelog or bump a version somewhere, but otherwise good to go. |
ecmendenhall
force-pushed
the
horsefacts/report-compile-time
branch
from
8435965
to
f065935
Compare
gakonst
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'd like to show time spent compiling a project in Forge. Other reporters could probably use this information, too.
Solution
Track elapsed compile time as a
std::time::Durationand pass it through to the configuredReporteras an extra arg toon_solc_success. See also foundry-rs/foundry#1145.PR Checklist