Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs path #12

Merged
merged 3 commits into from Jun 15, 2020
Merged

Update docs path #12

merged 3 commits into from Jun 15, 2020

Conversation

sbc64
Copy link
Collaborator

@sbc64 sbc64 commented Jun 15, 2020

When I ran cargo doc --open I would get this error:

 Documenting ethers v0.1.0 (/home/sebas/repos/eth2.0/ethers-rs/ethers)
error: `[secp256k1]` cannot be resolved, ignoring it.
       --> ethers/src/lib.rs:250:58
       |
250 | /// under the `abi` module, as well as the [`secp256k1`](secp256k1) and [`rand`](rand)
       |                                                                                          ^^^^^^^^^ cannot be resolved, ignoring
       |
...
error: `[rand]` cannot be resolved, ignoring it.
      --> ethers/src/lib.rs:250:82
       |
250 | /// under the `abi` module, as well as the [`secp256k1`](secp256k1) and [`rand`](rand)
       |                                                                                                                                ^^^^ cannot be resolved, ignoring
       |
      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`

error: aborting due to 2 previous errors

error: Could not document `ethers`.

This PR changes the docs url paths for both secp256k1 and rand. It is using the docs.rs docs but notice that the version of rand is not matching with Cargo.toml. 0.7.3 in the docs.rs url vs 0.7.2 used in Cargo). I used the docs.rs url so that it is consistent with the ethabi link in the same comment location.

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@gakonst gakonst merged commit 20da946 into master Jun 15, 2020
@gakonst gakonst deleted the update-docs-path branch June 15, 2020 11:29
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
* refactor(dapp): split out cli utils

* refactor(seth): split out cli utils

* refactor(dapp): split out executor

* refactor(dapp): move things around

* refactor: split out contract test runner

* refactor: split out artifacts from main

* refactor: split out multi-runner from main

* chore: pass backend by reference

* chore: move test pre-compilation to lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants