Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_paginated_logs fixes and refactoring #1328

Merged
merged 2 commits into from May 31, 2022
Merged

get_paginated_logs fixes and refactoring #1328

merged 2 commits into from May 31, 2022

Conversation

meetmangukiya
Copy link
Contributor

@meetmangukiya meetmangukiya commented May 31, 2022 •
edited

Motivation

from and to both blocks are inclusive in the filter range which leads to double loading of boundary blocks on pagination.

Solution

Load next page from last + 1 to last + 1 + page_size

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@meetmangukiya meetmangukiya changed the title fix(providers): do not load boundry blocks on every page get_paginated_logs fixes and refactoring May 31, 2022
mattsse
mattsse approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gakonst gakonst merged commit e0db2f0 into gakonst:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meetmangukiya @mattsse @gakonst