Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solc): remove compile_exact restriction #1329

Merged
merged 1 commit into from May 31, 2022
Merged

fix(solc): remove compile_exact restriction #1329

merged 1 commit into from May 31, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented May 31, 2022

Motivation

Ref foundry-rs/foundry#1776

this removes the compile_exact restriction, which after some investigation can cause some issues in following circumstances:

  • paths (or keys) of the contracts in the output differ from the input keys on windows
  • if we failed to resolve the complete graph properly (likely due to some parser limitations) this can filter out those contracts we missed but solc includes in the output.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes May 31, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - let's remove compile_exact in a follow up if it's non longer necessary

@gakonst gakonst merged commit 86e5af2 into gakonst:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst