Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(abigen): replace ethabi::Reader #1417

Merged
merged 6 commits into from Jun 27, 2022
Merged

refactor(abigen): replace ethabi::Reader #1417

merged 6 commits into from Jun 27, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 25, 2022

Motivation

Depends on #1416
Replace ethabi::Reader::read with HumanreadableParser::parse_type which has better tuple parsing

there's still some potential to unify AbiParser and HumanreadableParser, reason why they're different types, is that AbiParser can resolve custom struct types

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse force-pushed the matt/phase-out-ethabi-reader branch from 78400b1 to fba0b13 Compare June 25, 2022 17:02
@gakonst gakonst merged commit 659ac06 into gakonst:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst