Implement fastrlp traits for Signature #1444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deriving fastrlp
Encodable
andDecodable
traits for types that containSignature
would not be possible without implementingEncodable
andDecodable
forSignature
.Solution
fastrlp
as a dependency toethers-core
, meaning this conflicts with Implement fastrlp traits for Bytes #1443 for the time beingHash
onSignature
(just a convenience impl, not related to fastrlp traits)Signature
. This does not encode or decode a RLP header for a signature type, since types that would contain a signature (for example a signed transaction) are usually encoded as[...rest of object, v, r, s]
rather than[...rest of object, [v, r, s]]
.PR Checklist