Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make ethers-solc optional #1463

Merged
merged 4 commits into from Jul 6, 2022
Merged

chore: make ethers-solc optional #1463

merged 4 commits into from Jul 6, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 6, 2022

Motivation

Closes #1457

Solution

  • make optional
  • update features, add cfgs

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst
Copy link
Owner

gakonst commented Jul 6, 2022 •
edited

missing feature in examples/moonbeam_with_abi.rs - lgtm otherwise

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 6, 2022

added

@gakonst gakonst merged commit fb3fb16 into gakonst:master Jul 6, 2022
@plotchy plotchy mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider making ethers-solc optional
2 participants
@mattsse @gakonst