fix(providers): handle zst params in retry provider correctly #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes foundry-rs/foundry#2318
because we previously always serialized
params
in theRetryProvider
, zero sized types like()
, which are skipped byRequest
ended up asparams: "null"
, instead of being empty which is incompatible with hardhat for example.so instead of
{"id":1,"jsonrpc":"2.0","method":"eth_chainId"}
the retry provider was sending{"id":1,"jsonrpc":"2.0","method":"eth_chainId", "params": "null"}
Solution
add zero size check and delegate to wrapped provider
PR Checklist