Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EthError trait and derive #1549

Merged
merged 2 commits into from Aug 2, 2022
Merged

feat: add EthError trait and derive #1549

merged 2 commits into from Aug 2, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 2, 2022

Motivation

Add support for custom errors

Solution

  • introduce new EthError trait, basically same as EthCall with derive impl
    • unify some derive code for EthCall and EthError in calllike
  • support human readable error parsing
  • generate bindings for custom solidity errors, if there are more than 1 error in the abi, we generate an error enum enum <name>Errors {.. see Seaport test

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes Aug 2, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty reasonable

@gakonst gakonst merged commit 27a184d into gakonst:master Aug 2, 2022
@nambrot nambrot mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst