feat(core): add ability to take geth stderr #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* makes the geth logs accessible by using take() on the GethInstance stderr
18 tasks
mattsse
approved these changes
Jan 4, 2023
Comment on lines
+83
to
+84
| pub fn stderr(&mut self) -> Result<ChildStderr, GethInstanceError> { | ||
| self.pid.stderr.take().ok_or(GethInstanceError::NoStderr) |
There was a problem hiding this comment.
could also do an Option but since we already have NoStdErr, let's use this result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
GethInstancelogs are useful for understanding what geth is doing, and there is currently no way to extract thepid.stderrso the logs can be read.Solution
Implement a
stderrmethod onGethInstancethat usestake()to return aChildStderr, which can then be read with aBufReaderor other methods.PR Checklist