remove EthAbiType derive generated unwrap #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 15, 2023
Comment on lines
43
to
49
| quote_spanned! { f.span() => #name: iter | ||
| .next() | ||
| .ok_or_else(|| #core_crate::abi::InvalidOutputType(::std::format!( | ||
| "Struct field {:} doesn't have correspond token.", #name_str | ||
| ))) | ||
| .and_then(|t| #core_crate::abi::Tokenizable::from_token(t))? | ||
| } |
There was a problem hiding this comment.
I think we should just use an expect here, because there's already a len check so this is guaranteed to succeed, hence the unwrap.
There was a problem hiding this comment.
Although I don't have problems with expect, there is also https://rust-lang.github.io/rust-clippy/master/#expect_used lint kind which some people might want to warn about it.
There was a problem hiding this comment.
this error can never happen though
There was a problem hiding this comment.
I know.Just want to pass the lint check for unwrap in my situation. If you want expect, then expect it is.
mattsse
reviewed
Jan 15, 2023
zsluedem
force-pushed
the
EthAbiType-remove-unwrap-used
branch
from
108ca1a
to
8be05c3
Compare
zsluedem
force-pushed
the
EthAbiType-remove-unwrap-used
branch
from
8be05c3
to
9dcc5a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2053
Solution
Replace unwrap with safer method
PR Checklist