Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/geth): enable Clique mode #2063

Merged
merged 4 commits into from Jan 19, 2023
Merged

feat(core/geth): enable Clique mode #2063

merged 4 commits into from Jan 19, 2023

Conversation

gakonst
Copy link
Owner

@gakonst gakonst commented Jan 19, 2023

Allows instantiating Geth in Clique mode when provided with a SigningKey.

Extracts the logic from https://github.com/paradigmxyz/reth/pull/623/files#diff-99e7bcdfb85c75ffe5fb2ccfbc5fd8234fced6704c34b622fbf24289b8522515R210

cc @Rjected

Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not tested but looks good

Copy link
Owner Author

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging cautiously, and will iterate on it.

@gakonst gakonst merged commit b8fa524 into master Jan 19, 2023
@gakonst gakonst deleted the feat/geth-clique branch January 19, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants