Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(etherscan): Allow ClientBuilder to create Client without API key #2067

Merged
merged 1 commit into from Jan 22, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Jan 20, 2023

Motivation

Etherscan allows 1 request per 5 seconds if the API key is not defined

Solution

Make API key optional

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

… key

Etherscan allows 1 request per 5 seconds if the API key is not defined
@gakonst gakonst merged commit 50ef8a7 into gakonst:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants