feat(core): more type parsing #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 30, 2023
Comment on lines
102
to
111
| impl FromStr for NameOrAddress { | ||
| type Err = Infallible; | ||
| type Err = <Address as FromStr>::Err; | ||
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| Ok(Self::Name(s.to_string())) | ||
| if s.starts_with("0x") { | ||
| s.parse().map(Self::Address) | ||
| } else { | ||
| Ok(Self::Name(s.to_string())) | ||
| } | ||
| } |
Comment on lines
+648
to
+652
| n => { | ||
| if let Ok(n) = n.parse::<U64>() { | ||
| Ok(Self::Number(n)) | ||
| } else if let Ok(n) = n.parse::<u64>() { | ||
| Ok(Self::Number(n.into())) |
There was a problem hiding this comment.
This is no longer compliant with the rpc spec for block number, but I guess this is fine?
There was a problem hiding this comment.
Fine w/ me. More flexibility, and people create BlockNumber themselves, vs always parsing it out from the hex returned from RPC
gakonst
approved these changes
Jan 31, 2023
Comment on lines
+648
to
+652
| n => { | ||
| if let Ok(n) = n.parse::<U64>() { | ||
| Ok(Self::Number(n)) | ||
| } else if let Ok(n) = n.parse::<u64>() { | ||
| Ok(Self::Number(n.into())) |
There was a problem hiding this comment.
Fine w/ me. More flexibility, and people create BlockNumber themselves, vs always parsing it out from the hex returned from RPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upstreaming from foundry-cli/cast helper parsers
Solution
PR Checklist