Fix Signature Recovery Id & expose `verify` function #21

gakonst · 2020-06-17T06:34:00Z

Motivation

The recovery_id was stored as a u8. This means that EIP-155 signatures with larger chain_id's would fail (since we'd overflow the variable).

Storing v as u64 fixes this.

Also exposes a Signature.verify function, as per @tuxxy suggestion.

u8 would not work if a large chain_id was used

gakonst changed the base branch from master to gakonst/crypto-fixes June 17, 2020 06:34

gakonst force-pushed the gakonst/signature-verify branch from 2967475 to a906fa0 Compare June 17, 2020 06:35

Base automatically changed from gakonst/crypto-fixes to master June 17, 2020 06:38

fix(core): make Signature.v a u64 instead of a u8 and expose verify

afc525b

u8 would not work if a large chain_id was used

gakonst force-pushed the gakonst/signature-verify branch from a906fa0 to afc525b Compare June 17, 2020 06:39

gakonst merged commit 2c734f0 into master Jun 17, 2020

gakonst deleted the gakonst/signature-verify branch June 17, 2020 06:45