Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move etherscan api key env var matching to Chain enum #2204

Merged
merged 3 commits into from Feb 27, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Title, from ethers-etherscan to ethers-core::types::Chain, so that all the non-exhaustive chain matches are in the same file.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@gakonst gakonst merged commit 1861b98 into gakonst:master Feb 27, 2023
@DaniPopes DaniPopes deleted the chore/etherscan-api-key branch February 28, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants