New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: simplify test cleanup #2220

Merged

gakonst merged 1 commit into gakonst:master from mattsse:matt/simplify-testcleanup

Mar 5, 2023

Collaborator

mattsse commented Mar 1, 2023

get rid of some weird IO errors:
https://github.com/gakonst/ethers-rs/actions/runs/4305262960/jobs/7507450686

no need for close: executed in drop impl
no need for drop: dropped when out of scope


          test: simplify test cleanup

3bc55f7

mattsse mentioned this pull request

DO NOT MERGE: fix(ci): geth data dir cleanup delay #2231

Closed

Contributor

rkrasiuk commented Mar 5, 2023 •

edited

no need for close: executed in drop impl

these aren't equivalent since we call unwrap. see https://docs.rs/tempfile/latest/tempfile/struct.TempDir.html#method.close

gakonst merged commit a4f1a7b into gakonst:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment