Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abigen): support empty events #2263

Merged
merged 1 commit into from Mar 15, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 15, 2023

Motivation

Closes #2261

support unit structs in EthEvent

decoding is just checking the signature.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@gakonst gakonst merged commit 72be337 into gakonst:master Mar 15, 2023
9 of 12 checks passed
@FrankieIsLost
Copy link
Contributor

thank you!

@FrankieIsLost
Copy link
Contributor

FYI, I'm not sure if the issue is fixed yet. I pulled in the fix and tried to run forge bind on the example contract from #2261 , and now get an error that looks like the following:

error[E0433]: failed to resolve: could not find `ethers_core` in the list of imported crates
   --> src/event_emitter.rs:292:9
    |
292 |         ::ethers::contract::EthEvent,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `ethers_core` in the list of imported crates
    |
    = note: this error originates in the derive macro `::ethers::contract::EthEvent` (in Nightly builds, run with -Z macro-backtrace for more info)

I tried running forge bind on a larger project, and get the same type of error, but only on empty events.

@mattsse mattsse mentioned this pull request Mar 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abigen does not handle zero-parameter events
3 participants